Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add INA219 battery sensor #2380

Merged
merged 19 commits into from
Jun 8, 2024
Merged

feat: Add INA219 battery sensor #2380

merged 19 commits into from
Jun 8, 2024
+110 −5

Conversation

saeugetier
Copy link

Add an additional battery sensor: The INA2019 is a very commonly used battery sensor. This allows to measure the battery voltage and shut down the PRI Jukebox on low battery.

@s-martin s-martin added enhancement future3 Relates to future3 development labels Jun 2, 2024
@s-martin
Copy link
Collaborator

s-martin commented Jun 2, 2024

Hi, thanks for this addition!

We will look into it and get back to you shortly.

pabera
pabera reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@pabera pabera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition. I am not super familiar which battery to chose so I always use a consumer battery pack, but then I am lacking the battery monitor. I'd love to see your set up and types of battery used and how everything is assembled. I guess this could also be great in the documentation

src/jukebox/components/battery_monitor/batt_mon_i2c_ina219/__init__.py Outdated Show resolved Hide resolved
src/jukebox/components/battery_monitor/batt_mon_i2c_ina219/__init__.py Outdated Show resolved Hide resolved
src/jukebox/components/battery_monitor/batt_mon_i2c_ina219/__init__.py Outdated Show resolved Hide resolved
@saeugetier
Copy link
Author

saeugetier commented Jun 5, 2024 •
edited
Loading

Thanks for this addition. I am not super familiar which battery to chose so I always use a consumer battery pack, but then I am lacking the battery monitor. I'd love to see your set up and types of battery used and how everything is assembled. I guess this could also be great in the documentation

I think this battery monitor can be used with consumer battery packs. The ADC measures the voltage of the battery. If you have access to the raw voltage of the battery, then the battery can be monitored.

@pabera
Copy link
Collaborator

pabera commented Jun 7, 2024

I think this battery monitor can be used with consumer battery packs. The ADC measures the voltage of the battery. If you have access to the raw voltage of the battery, then the battery can be monitored.

I have a simple USB cable from my battery pack to the Raspi. If I cut the cable and put the sensor in between, this should work it seems.

pabera
pabera approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@pabera pabera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to test this as I am missing the device.
Code looks good though!

@s-martin s-martin added this to the v3.6 milestone Jun 7, 2024
@s-martin s-martin merged commit f2a1730 into MiczFlor:future3/develop Jun 8, 2024
9 checks passed
@s-martin
Copy link
Collaborator

s-martin commented Jun 8, 2024

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-martin s-martin s-martin approved these changes

@pabera pabera pabera approved these changes

Assignees
No one assigned
Labels
enhancement future3 Relates to future3 development
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@saeugetier @s-martin @pabera